Skip to content

yes: simplify logic for buffer creation#11727

Merged
RenjiSann merged 1 commit into
uutils:mainfrom
oech3:yes-buf
Apr 9, 2026
Merged

yes: simplify logic for buffer creation#11727
RenjiSann merged 1 commit into
uutils:mainfrom
oech3:yes-buf

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Apr 9, 2026 •
edited
Loading

  • Reduce reference to the same const.
  • Simplify comments

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cp/link-heap is now passing!
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cp/link-heap is now passing!
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@oech3 oech3 marked this pull request as ready for review April 9, 2026 15:08
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 9, 2026

Merging this PR will improve performance by 3.66%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 308 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation du_max_depth_balanced_tree[(6, 4, 10)] 26.4 ms 25.5 ms +3.66%

Comparing oech3:yes-buf (ea4c060) with main (130de6f)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@RenjiSann RenjiSann merged commit 33745a0 into uutils:main Apr 9, 2026
169 checks passed
@oech3 oech3 deleted the yes-buf branch April 9, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @RenjiSann